fix: Relates to #140. Update React Native to 0.56 #209

ltfschoen · 2019-01-21T00:03:40Z

No description provided.

ltfschoen · 2019-01-29T20:35:10Z

Progress update:

Updates have been made in branch 'luke-140-update-react-native-test' (ignore the "release" and "config" properties, and "commit-wizard" value, that appear to have been added automatically by a hook, but I first have to overcome this issue #214 so that I know the updates aren't breaking the build or causing any device errors on Android. I'll also need help from someone else to confirm that it build and doesn't cause any device errors on an iPhone device

…vtools' from 'setup.js' error

ltfschoen · 2019-01-30T06:43:10Z

I've only been able to update to react-native 0.56. Please kindly check if these changes also work on iOS. I've only tested that it builds and loads successfully on an Android Samsung Galaxy 8 Note.

I've attempted to further update to react-native 0.57.8 in this branch 'luke-140-update-react-native-rn-0.57.8-wip' but I got errors shown below:

> Configure project :react-native-vector-icons 
WARNING: The option 'android.enableAapt2' is deprecated and should not be used anymore.
Use 'android.enableAapt2=true' to remove this warning.
It will be removed at the end of 2018.
WARNING: Configuration 'compile' is obsolete and has been replaced with 'implementation'.
It will be removed at the end of 2018
WARNING: The specified Android SDK Build Tools version (26.0.1) is ignored, as it is below the minimum supported version (27.0.3) for Android Gradle Plugin 3.1.0.
Android SDK Build Tools 27.0.3 will be used.
To suppress this warning, remove "buildToolsVersion '26.0.1'" from your build.gradle file, as each version of the Android Gradle Plugin now has a default version of the build tools.

Task :react-native-camera:compileDebugJavaWithJavac FAILED

/Users/scon/code/src/paritytech/parity-signer/node_modules/react-native-camera/android/src/main/java/org/reactnative/camera/CameraModule.java:12: error: cannot find symbol

import com.facebook.react.uimanager.UIBlock;

^

symbol:   class UIBlock

location: package com.facebook.react.uimanager

/Users/scon/code/src/paritytech/parity-signer/node_modules/react-native-camera/android/src/main/java/org/reactnative/camera/CameraModule.java:216: error: cannot find symbol

uiManager.addUIBlock(new UIBlock() {

^

symbol:   class UIBlock

location: class CameraModule

/Users/scon/code/src/paritytech/parity-signer/node_modules/react-native-camera/android/src/main/java/org/reactnative/camera/CameraModule.java:237: error: cannot find symbol

uiManager.addUIBlock(new UIBlock() {

^

symbol:   class UIBlock

location: class CameraModule

/Users/scon/code/src/paritytech/parity-signer/node_modules/react-native-camera/android/src/main/java/org/reactnative/camera/CameraModule.java:259: error: cannot find symbol

uiManager.addUIBlock(new UIBlock() {

^

symbol:   class UIBlock

location: class CameraModule

/Users/scon/code/src/paritytech/parity-signer/node_modules/react-native-camera/android/src/main/java/org/reactnative/camera/CameraModule.java:282: error: cannot find symbol

uiManager.addUIBlock(new UIBlock() {

^

symbol:   class UIBlock

location: class CameraModule

/Users/scon/code/src/paritytech/parity-signer/node_modules/react-native-camera/android/src/main/java/org/reactnative/camera/CameraModule.java:305: error: cannot find symbol

uiManager.addUIBlock(new UIBlock() {

^

symbol:   class UIBlock

location: class CameraModule

/Users/scon/code/src/paritytech/parity-signer/node_modules/react-native-camera/android/src/main/java/org/reactnative/camera/CameraModule.java:326: error: cannot find symbol

uiManager.addUIBlock(new UIBlock() {

^

symbol:   class UIBlock

location: class CameraModule

/Users/scon/code/src/paritytech/parity-signer/node_modules/react-native-camera/android/src/main/java/org/reactnative/camera/CameraModule.java:352: error: cannot find symbol

uiManager.addUIBlock(new UIBlock() {

^

symbol:   class UIBlock

location: class CameraModule

/Users/scon/code/src/paritytech/parity-signer/node_modules/react-native-camera/android/src/main/java/org/reactnative/camera/events/BarCodeReadEvent.java:37: error: method init in class Event cannot be applied to given types;

super.init(viewTag);

^

required: int,long

found: int

reason: actual and formal argument lists differ in length

where T is a type-variable:

T extends Event declared in class Event

/Users/scon/code/src/paritytech/parity-signer/node_modules/react-native-camera/android/src/main/java/org/reactnative/camera/events/PictureTakenEvent.java:22: error: method init in class Event cannot be applied to given types;

event.init(viewTag);

^

required: int,long

found: int

reason: actual and formal argument lists differ in length

where T is a type-variable:

T extends Event declared in class Event

/Users/scon/code/src/paritytech/parity-signer/node_modules/react-native-camera/android/src/main/java/org/reactnative/camera/events/BarcodeDetectionErrorEvent.java:29: error: method init in class Event cannot be applied to given types;

super.init(viewTag);

^

required: int,long

found: int

reason: actual and formal argument lists differ in length

where T is a type-variable:

T extends Event declared in class Event

/Users/scon/code/src/paritytech/parity-signer/node_modules/react-native-camera/android/src/main/java/org/reactnative/camera/events/BarcodesDetectedEvent.java:40: error: method init in class Event cannot be applied to given types;

super.init(viewTag);

^

required: int,long

found: int

reason: actual and formal argument lists differ in length

where T is a type-variable:

T extends Event declared in class Event

/Users/scon/code/src/paritytech/parity-signer/node_modules/react-native-camera/android/src/main/java/org/reactnative/camera/events/PictureSavedEvent.java:27: error: method init in class Event cannot be applied to given types;

super.init(viewTag);

^

required: int,long

found: int

reason: actual and formal argument lists differ in length

where T is a type-variable:

T extends Event declared in class Event

/Users/scon/code/src/paritytech/parity-signer/node_modules/react-native-camera/android/src/main/java/org/reactnative/camera/events/CameraReadyEvent.java:22: error: method init in class Event cannot be applied to given types;

event.init(viewTag);

^

required: int,long

found: int

reason: actual and formal argument lists differ in length

where T is a type-variable:

T extends Event declared in class Event

/Users/scon/code/src/paritytech/parity-signer/node_modules/react-native-camera/android/src/main/java/org/reactnative/camera/events/FaceDetectionErrorEvent.java:28: error: method init in class Event cannot be applied to given types;

super.init(viewTag);

^

required: int,long

found: int

reason: actual and formal argument lists differ in length

where T is a type-variable:

T extends Event declared in class Event

/Users/scon/code/src/paritytech/parity-signer/node_modules/react-native-camera/android/src/main/java/org/reactnative/camera/events/CameraMountErrorEvent.java:27: error: method init in class Event cannot be applied to given types;

super.init(viewTag);

^

required: int,long

found: int

reason: actual and formal argument lists differ in length

where T is a type-variable:

T extends Event declared in class Event

/Users/scon/code/src/paritytech/parity-signer/node_modules/react-native-camera/android/src/main/java/org/reactnative/camera/events/FacesDetectedEvent.java:50: error: method init in class Event cannot be applied to given types;

super.init(viewTag);

^

required: int,long

found: int

reason: actual and formal argument lists differ in length

where T is a type-variable:

T extends Event declared in class Event

/Users/scon/code/src/paritytech/parity-signer/node_modules/react-native-camera/android/src/main/java/org/reactnative/camera/events/TextRecognizedEvent.java:55: error: method init in class Event cannot be applied to given types;

super.init(viewTag);

^

required: int,long

found: int

reason: actual and formal argument lists differ in length

where T is a type-variable:

T extends Event declared in class Event

Note: Some input files use or override a deprecated API.

Note: Recompile with -Xlint:deprecation for details.

Note: /Users/scon/code/src/paritytech/parity-signer/node_modules/react-native-camera/android/src/main/java/com/google/android/cameraview/Camera2.java uses unchecked or unsafe operations.

Note: Recompile with -Xlint:unchecked for details.

18 errors

FAILURE: Build failed with an exception.

What went wrong:

Execution failed for task ':react-native-camera:compileDebugJavaWithJavac'.


Compilation failed; see the compiler error output for details.



Try:

Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.


Get more help at https://help.gradle.org


BUILD FAILED in 1s

41 actionable tasks: 1 executed, 40 up-to-date

Could not install the app on the device, read the error above for details.

Make sure you have an Android emulator running or a device connected and have

set up your Android development environment:

https://facebook.github.io/react-native/docs/getting-started.html

lexfrl

Why delete .babelrc?

ltfschoen · 2019-01-30T23:45:31Z

Why delete .babelrc?

Because in Babel 7 we use babel.config.js for project-wide configuration https://babeljs.io/docs/en/config-files, and this appears to be a project-wide configuration rather than a file-relative configuration (where you use .babelrc)

lexfrl · 2019-02-12T15:57:45Z

why merge? Did anybody test it on iOS?

I've only been able to update to react-native 0.56. Please kindly check if these changes also work on iOS. I've only tested that it builds and loads successfully on an Android Samsung Galaxy 8 Note.

maciejhirsz · 2019-02-12T20:58:08Z

Looks pretty innocuous to me, it's only touching JS VM parts. I'm hoping to test iOS builds with Thibo next week on hardware.

lexfrl · 2019-02-13T23:11:26Z

It's a major upgrade of react-native. The devil in the detail: iOS JS VM (JavascriptCore) is a different one than Android's (V8). These tiny bits could break anything.

ltfschoen added 3 commits January 21, 2019 11:02

fix: Relates to #140. Update React Native to 0.57.8

258a3ae

fix: Bump CI and required Node.js version in package.json to Node 8

b757a49

chore: merge latest from master

8b1f738

ltfschoen changed the title ~~fix: Relates to #140. Update React Native to 0.57.8~~ WIP: Relates to #140. Update React Native to 0.57.8 Jan 29, 2019

ltfschoen added A3-inprogress labels Jan 29, 2019

ltfschoen changed the title ~~WIP: Relates to #140. Update React Native to 0.57.8~~ fix: Relates to #140. Update React Native to 0.57.8 Jan 29, 2019

ltfschoen added 4 commits January 30, 2019 15:28

chore: Update dependencies. Cannot update to reactive-native 0.58.3

d270a6f

fix: Add @babel/plugin-proposal-class-properties

d99c2dd

chore: Boost version of babel-preset-react-native to 5.0.2

5c229fd

chore: Update to React Native 0.56 to fix Cannot find module 'setupDe…

961dbba

…vtools' from 'setup.js' error

ltfschoen changed the title ~~fix: Relates to #140. Update React Native to 0.57.8~~ fix: Relates to #140. Update React Native to 0.56 Jan 30, 2019

ltfschoen added A0-pleasereview and removed A3-inprogress labels Jan 30, 2019

fix: Fixes error ReferenceError: regeneratorRuntime is not defined

cdec07d

ltfschoen added A0-pleasereview and removed A3-inprogress labels Jan 30, 2019

lexfrl suggested changes Jan 30, 2019

View reviewed changes

maciejhirsz added A8-looksgood and removed A0-pleasereview labels Feb 11, 2019

maciejhirsz approved these changes Feb 11, 2019

View reviewed changes

maciejhirsz merged commit 4cd616b into master Feb 11, 2019

maciejhirsz deleted the luke-140-update-react-native branch February 11, 2019 16:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Relates to #140. Update React Native to 0.56 #209

fix: Relates to #140. Update React Native to 0.56 #209

ltfschoen commented Jan 21, 2019 •

edited

Loading

ltfschoen commented Jan 29, 2019 •

edited

Loading

ltfschoen commented Jan 30, 2019

lexfrl left a comment

ltfschoen commented Jan 30, 2019

lexfrl commented Feb 12, 2019 •

edited

Loading

maciejhirsz commented Feb 12, 2019

lexfrl commented Feb 13, 2019 •

edited

Loading

fix: Relates to #140. Update React Native to 0.56 #209

fix: Relates to #140. Update React Native to 0.56 #209

Conversation

ltfschoen commented Jan 21, 2019 • edited Loading

ltfschoen commented Jan 29, 2019 • edited Loading

ltfschoen commented Jan 30, 2019

lexfrl left a comment

Choose a reason for hiding this comment

ltfschoen commented Jan 30, 2019

lexfrl commented Feb 12, 2019 • edited Loading

maciejhirsz commented Feb 12, 2019

lexfrl commented Feb 13, 2019 • edited Loading

ltfschoen commented Jan 21, 2019 •

edited

Loading

ltfschoen commented Jan 29, 2019 •

edited

Loading

lexfrl commented Feb 12, 2019 •

edited

Loading

lexfrl commented Feb 13, 2019 •

edited

Loading